theforeman / puppet-foreman_proxy

Puppet module for Foreman Smart Proxy

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

22.1.0 release is missing dep on puppet/mosquitto

jhoblitt opened this issue · comments

It appears that templates/plugin/remote_execution_ssh.yml.erb is causing foreman_proxy::plugin::remote_execution::mosquitto to be evaluated regardless if it the class is declared in the manifest.

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Could not find declared class mosquitto (file: /etc/puppetlabs/code/environments/IT_3497_foreman3/modules/foreman_proxy/manifests/plugin/remote_execution/mosquitto.pp, line: 36, column: 3) on node foreman.dev.XXX

Which then fails as puppet/mosquitto isn't a declared dependency in metadata.json.

I take that back,foreman_proxy::plugin::remote_execution::script is unconditionally declaring foreman_proxy::plugin::remote_execution::mosquitto.

I am at a bit of a loss as to how the acceptance tests were running...

oh... modules are being pulled from fixtures... configure_beaker(modules: :fixtures) do |host|