theforeman / puppet-foreman_proxy

Puppet module for Foreman Smart Proxy

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dependencies to theforeman-puppet and theforeman-foreman are wrong

mzhaase opened this issue · comments

Current dependencies are as follows:

"dependencies": [
    ...
    {
      "name": "theforeman/foreman",
      "version_requirement": ">= 8.0.0 < 12.0.0"
    },
    {
      "name": "theforeman/puppet",
      "version_requirement": ">= 4.2.0 < 12.0.0"
    },
    ...
    {
      "name": "puppet/extlib",
      "version_requirement": ">= 3.0.0 < 4.0.0"
    },
    ...

However, theforeman/foreman and theforeman/puppet < 10.0.0 have the following dependency for extlib:

   {
      "name": "puppet/extlib",
      "version_requirement": ">= 0.11.3 < 3.0.0"
    }

As such, while the code itself may be compatible, installation fails anyway due to dependency missmatch.

So you're saying we should raise the minimum versions? I can see that.

Since de facto no one can install foreman-proxy 10.0.0 with foreman 8.0.0 and puppet 4.2.0, it would make sense to raise it all to 10 I think.