thecodingmachine / graphqlite

Use PHP Attributes/Annotations to declare your GraphQL API

Home Page:https://graphqlite.thecodingmachine.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Porpaginas is not maintained

l-you opened this issue · comments

commented

I have weird notices such as Porpaginas\Result::count() should either be compatible with Countable::count() while running tests in graphqlite
Look at beberlei/porpaginas#23
This PR is not being merged for a 5 month

Should we drop beberlei/porpaginas and replace it with own graphqlite pagination helper?

Seems like with next major php version we will be forced to do so

Let's see if we can get it merged and tagged. But if not, yea - probably need to look at bringing that into the lib and remove an external dependency.

@bladl it's now merged and 2.0 tagged.

#558 was just created as well. I assume we don't need to maintain 1.2 support here.

commented

Im glad to see beberlei/porpaginas still alive after a long time.