thebuilder / react-scroll-percentage

Monitor the scroll percentage of a component inside the viewport, using the IntersectionObserver API

Home Page:https://thebuilder.github.io/react-scroll-percentage/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

A dependency breaks the build (hooks in alpha)

fael opened this issue · comments

FOA, thank you for this bright idea.
Because you added support to hooks in react-intersection-observer which got updated to version ^6.1.0, it breaks a project using 16.6.3.

screenshot 2018-12-06 at 15 31 04

Do you think you can lock it? Or it is preferable to users using your lib to shrinkwrap the package? What's your suggestion?

That's interesting. It shouldn't break unless you are trying to use the hooks. I'll have a look at it.👌

I'm not using the alpha version on my projects, and it doesn't cause this error.

You should be able to fix it using Yarn resolutions to lock the version of react-intersection-observer for now

I can't seem to replicate this issue.
Can you recreate it in a Codesandbox?

I've published a new version (3.0.0) which upgrades the build process and dependencies. See if it's still an issue with this version.