theOGognf / finagg

A Python package for aggregating and normalizing historical data from popular and free financial APIs.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Better env configuration

theOGognf opened this issue · comments

Having a separate class for environment configuration is a bit verbose. This can probably be slimmed down by just passing args directly to the environment instead of a dictionary. Although, I'm not sure if RLlib supports those environments.

At least instantiating the configs from a dict can be done with pydantic or dacite. Probably can't get around defining configs separately.

Switched to using pydantic. Given the current nature of the wrappers, the configuration detail is fine.