thblt / write-yourself-a-git

Learn Git by reimplementing it from scratch

Home Page:https://wyag.thb.lt

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SHA-1 vs SHA-256

jflaherty opened this issue · comments

Have you thought of using SHA-256 since Git is pretty close to switching to SHA-256 in the near future due to collisions found in the wild?

This is a good idea, especially since even git's algorithm isn't sha1 anymore, but for a toy implementation I think it's best to wait until git itself has achieved its transition to the new hash algorithm. For now, I'd rather be widely compatible than cryptographically secure.

I'm leaving the issue open until then.

Thanks!