thash / asana

Asana command line Client

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DEPRECATED Action signature

hug33k opened this issue · comments

Hi,

Doesn't matter the action I choose, I've got this error message. It doesn't disturb the client, I can still do anything I want but I hope you could fix it, if ever cli changes something and makes your client no longer functional.

$>asana ts
 0 [ 2016-06-20 ] Task ...
DEPRECATED Action signature.  Must be `cli.ActionFunc`.  This is an error in the application.  Please contact the distributor of this application if this is not you.  See https://github.com/urfave/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature

I have the same error

@hug33k, @wakest, thanks for reporting the issue. I understand it's caused by cli library update.

According to 2016-04-30 update, surely cli returns deprecation message.

Specifying an Action with the legacy return signature of func(*cli.Context) will produce a deprecation message to stderr

However currently latest cli library does not return "DEPRECATED" message you referred, because of the change following issue & commit.

urfave/cli#507
urfave/cli@8e6aa34

Anyway I need to follow the change, but I guess you could avoid the deprecated message by updating cli to the latest version. If I misunderstand something, please let me know.