Aggregations produce incorrect results depending on label ordering
Reprazent opened this issue · comments
Playing around with a simple query using the new promql engine we noticed different results for aggregations based on label ordering in the aggregation:
The top result is the correct one.
Trying this out for GitLab.com in https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/1996
Build information:
| version | 0.29.0 |
|---|---|
| 194e1fadf4302341a0c70c28c0e3f3c658616c19 | |
| HEAD | |
| root@a0c7bba6c208 | |
| 20221103-14:28:25 | |
| go1.19.3 |
Hey @Reprazent, thanks for reporting this. I believe we already fixed it in #73.
Are you using the engine in Thanos, and which version are you using?
@fpetkovski Thanks for your swift reply! We were using the engine in Thanos. v0.29.0 194e1fadf4302341a0c70c28c0e3f3c658616c19. Would this be solved by upgrading to 0.30?
@fpetkovski It looks like it would, the version in v0.30.0 is d68c813, which includes #73.
I'll close this, sorry for the noise!
No worries, feel free to reopen this issue if you still notice the same problem.