TypeError: Object [object Object] has no method 'lightBox'

Question

TypeError: Object [object Object] has no method 'lightBox'

rjackson opened this issue 6 years ago · comments

https://sentry.io/team-fortress-wiki/tfwiki-prod/issues/440812322/

TypeError: Object [object Object] has no method 'lightBox'
  at Function.jQuery.extend.each (/w/load.php:5:235)
  at jQuery.fn.jQuery.each (/w/load.php:2:222)
  at fire (/w/load.php:45:122)
  at Object.self.add [as done] (/w/load.php:45:656)
  at jQuery.fn.ready (/w/load.php:49:63)
...
(1 additional frame(s) were not displayed)

Object [object Object] has no method 'lightBox'

Rob Jackson · Answer 1 · Mon Mar 12 2018 22:09:42 GMT+0800 (China Standard Time)

Source: https://wiki.teamfortress.com/wiki/MediaWiki:Common.js

Code beginning // Lightbox stuff

Looks like a case of our MediaWiki:Common.js code firing before MediaWiki's loaded its module's code.

Rob Jackson · Answer 2 · Tue Mar 13 2018 00:39:12 GMT+0800 (China Standard Time)

The sole purpose of this code is to apply TF2-style branding to the lightbox, so its non-essential. If we can't stop it clogging our error logs, lets drop it.

Rob Jackson · Answer 3 · Tue Mar 13 2018 00:59:11 GMT+0800 (China Standard Time)

Correction: This adds the lightbox functionality to all images... which GeeQuBox should be doing, but isn't. 🤔

Regardless, removed for now. Will re-evaluate once Slimbox is in-place.

Rob Jackson · Answer 4 · Tue Mar 13 2018 01:27:55 GMT+0800 (China Standard Time)

Slimbox is also old and terrible.

Wikimedia now use this, which looks pretty solid: https://www.mediawiki.org/wiki/Extension:MultimediaViewer

Rob Jackson · Answer 5 · Tue Mar 13 2018 01:44:50 GMT+0800 (China Standard Time)

Replaced GeeQuBox with MultimediaViewer in b48ec88. Wiki should be happier now.