Giters

tfjgeorge / nngeometry

{KFAC,EKFAC,Diagonal,Implicit} Fisher Matrices and finite width NTKs in PyTorch

Home Page:https://nngeometry.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Adding support for Conv1d layers

Xuzzo opened this issue · comments

commented

Hello and thanks again for your work.

Would it be possible to add support for Conv1d layers in K-FAC?

Thanks

commented

Hi,
this PR: #76 should do it.

I also implemented EKFAC if you are interested, it gives a more accurate FIM, at a slightly higher computational cost. It requires an extra call to M_ekfac.update_diag(loader) after your FIM is instantiated.

commented

Hi,
thank you very much for the help! Closing the issue.