support custom `testid` in the Chrome Extension

Question

support custom `testid` in the Chrome Extension

smeijer opened this issue 4 years ago · comments

Stephan Meijer commented 4 years ago

Summary 💡

The title says it all.

Motivation 🔦

https://twitter.com/wescopeland_/status/1275800945331441668?s=20

Bianca Del Carretto · Answer 1 · Sun Jun 28 2020 05:15:04 GMT+0800 (China Standard Time)

Hey!
Could I maybe have an example of a custom testId that the Chrome extension should support?
Thanks!

Stephan Meijer · Answer 2 · Sun Jun 28 2020 05:25:37 GMT+0800 (China Standard Time)

Every possible element attribute.

https://testing-library.com/docs/dom-testing-library/api-configuration

Bianca Del Carretto · Answer 3 · Sun Jun 28 2020 05:31:01 GMT+0800 (China Standard Time)

Ok, I got it. Thank you very much!

Bianca Del Carretto · Answer 4 · Sun Jun 28 2020 15:59:34 GMT+0800 (China Standard Time)

I could give it a shot.
I have two question about the implementation:

should we enable this feature in testing-playground too?
if you have already thought about this: in order to retrieve the desired attribute to be used as testId should we add an input somewhere where the user could insert it?

Stephan Meijer · Answer 5 · Sun Jun 28 2020 17:51:22 GMT+0800 (China Standard Time)

Yes, I think we should keep the web version and the chrome version as equal as possible. That way a user could just copy/paste code from his tests (debug output) to the web version, and share the link with others to get some advice.
Yes, we would need an input. I have some idea's about the interface, but I haven't figured it out exactly. I think we need to add a settings modal similar to how react-devtools does it. The settings modal for the web version can follow later on, as long as the technical implementation (the id-attribute config) works on both.

If we need a library for the modal, we can use https://reacttraining.com/reach-ui/dialog

Bianca Del Carretto · Answer 6 · Sun Jun 28 2020 23:27:42 GMT+0800 (China Standard Time)

Ok, I think I have understood.
If it sounds good to you, I could start adding a settings modal to the extension in which a user could insert the attribute to be used as custom test id.

Stephan Meijer · Answer 7 · Mon Jun 29 2020 02:46:45 GMT+0800 (China Standard Time)

Sounds great @delca85.

Stephan Meijer · Answer 8 · Wed Jul 01 2020 00:18:36 GMT+0800 (China Standard Time)

@delca85, I'm working on an interface update to support a setting modal. So don't worry too much about where you're going to place that input. Just focus on figuring out how we can configure testing-lib to apply that setting.

Bianca Del Carretto · Answer 9 · Wed Jul 01 2020 00:23:43 GMT+0800 (China Standard Time)

@smeijer, great! I have already implemented the functionality but I still have to apply style to the modal. If it's ok for you I could push tonight the code I have and later we could merge our work.

Stephan Meijer · Answer 10 · Wed Jul 01 2020 00:25:11 GMT+0800 (China Standard Time)

Sounds good to me @delca85

Stephan Meijer · Answer 11 · Wed Jul 08 2020 02:26:08 GMT+0800 (China Standard Time)

closed by #227