Giters

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.

Home Page:https://dotnet.testcontainers.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Enhancement]: Update mssql default image tag to 2022 from 2019

Meir017 opened this issue · comments

commented

Problem

The default image is mcr.microsoft.com/mssql/server:2019-CU18-ubuntu-20.04
see https://mcr.microsoft.com/en-us/product/mssql/server/about

That value hasn't been updated since 2022
image

Solution

Update the image tag to be mcr.microsoft.com/mssql/server:2022-CU10-ubuntu-22.04

Benefit

More secure and updated docker image

Alternatives

manually override the image tag when using this library

Would you like to help contributing this enhancement?

Yes

commented

manually override the image tag when using this library

This is our recommendation. I noticed it is not covered by the best practices. I will update them later today. Usually, we try to avoid updating the default image version to prevent introducing breaking changes for developers when they update the dependency.

commented

@HofmeisterAn can we update the c# example https://testcontainers.com/modules/mssql/ to override the image tag to a more recent one?

commented

I think the testcontainers/community-module-registry repository is public. Could you please create an issue or PR there? This should be the related line. Otherwise, @eddumelendez will certainly help you with any further questions or guidance on how to update the version. I am no longer with AJ/Docker.