Plans for moving from legacy driver?
nacc opened this issue · comments
🗣️ Foreword
Thank for taking the time to fill this feature request fully. Without it we may not be able to , and the issue may be closed without resolution.
🙍 Problem Statement
In trying to work through some hairy chef-internal changes that I needed to stage, I was hoping to leverage some provisioner: variables (e.g., retry_on_exit_code). However, because kitchen-digitalocean is a "legacy" Driver (inherits from SSHBase, aiui), the provisioner variables aren't actually used, because the driver does the converge (over ssh) rather than the provisioner.
❔ Possible Solution
I am not entirely sure what is necessary to not be a legacy Driver, but I'm happy to invest time to do the code changes. I want to find out, first, though, if there is interest in that being done and if such a PR would be acceptable.
⤴️ Describe alternatives you've considered
I suppose an alternative would be to add support for those variables to the kitchen-digitalocean Driver directly, but that seems like the wrong direction if deprecation of legacy Drivers is really the intention upstream.
@tas50 any thoughts on this?
One of the tasks for the new team is to cleanup internal implementations of all the drives so this is on the list.
Ty!