terraform-ibm-modules / terraform-ibm-hpcs

Create and configure an IBM Cloud Hyper Protect Crypto Services instance.

Home Page:https://cloud.ibm.com/docs/hs-crypto

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Why the provision_instance var?

l2fprod opened this issue · comments

Why do we have this parameter?

count = (var.provision_instance == true ? 1 : 0)

If I want the provisioning to be optional, I can remove the module in my terraform or put the count in my terraform, like this:

module "hpcs" {
  count = tobool(var.use_hpcs) ? 1 : 0
  source                 = "github.com/terraform-ibm-modules/terraform-ibm-hpcs//modules/ibm-hpcs-instance"

  provision_instance     = tobool(var.use_hpcs)
  resource_group_id      = data.terraform_remote_state.account_structure.outputs.resource_group.id
  service_name           = "${var.basename}-hpcs"
  region                 = var.region
  plan                   = "standard"
  tags                   = concat(var.tags, ["service"])
  number_of_crypto_units = 2
}

Also if you keep provision_instance, the output should be changed to return the instance .0 if provision_instance is set.

It was added to contro provisioning..
It is removed now..
Thanks,