Adding "idle-timeout-seconds" terraform variable in for vertex_workbench_notebook pipeline

[Imran Topuz]

TL;DR

Hello,

We wuld like to add new terraform variable (idle-timeout-seconds) to control idle vertex ai notebooks for vertex_workbench_notebook. Probably needs to be added into "vertex.tf"
Could you please help us ?
Thanks,
İmran

Terraform Resources

https://cloud.google.com/vertex-ai/docs/workbench/instances/idle-shutdown
https://github.com/terraform-google-modules/terraform-docs-samples/blob/HEAD/vertex_ai/workbench_idle_shutdown/main.tf

Detailed design

No response

Additional information

No response

[Sampath Kumar]

Hi Imran, thank you for this request.

If you like to contribute, you can check details from https://github.com/terraform-google-modules/terraform-docs-samples/blob/main/CONTRIBUTING.md

To keeps examples simple we don't use any locals or variables. An alternative is to add code comments in the samples.

Example

resource "google_workbench_instance" "default" {
  name     = "workbench-instance-example"
  ...
  ...
  ...
    metadata = {
      # Add your comments here
      #   Example: default idle-timeout-seconds is XYZ mins
      idle-timeout-seconds = "10800"
    }
  }
}

Hope you this helps

[Katie McLaughlin]

As of 5.17.0, google_notebook_instance is deprecated, and the docs suggest using google_workbench_instance instead. As you linked, this resource already includes the idle-timeout option you are after.