Need to update comments in the terraform sample
savijatv opened this issue · comments
Savija Vijayaraghavan commented
- I think the comment at line#47 should be specific to the network instead of "secret default". Please review and change accordingly.
- The comment at line#53 needs more information. Maybe explain why scopes are mentioned here. Something similar to "To avoid embedding secret keys or user credentials in the instances, Google recommends that you use custom service accounts with the following access scopes."
- Should we specify the 'email' field in the service account block?
Savija Vijayaraghavan commented
/assign @askubis