feat: Request for Clean for Cloud SQL folder samples
msampathkumar opened this issue · comments
TL;DR
feat: Request for Clean for Cloud SQL folder samples
This is clean up is not related to modification of code but related to re-organising of some cloud sql samples locations and their folders.
The following is the list of samples need these clean up
- cloud_sql/database_basic/main.tf
- cloud_sql/database_instance_my_sql/main.tf
- cloud_sql/database_instance_postgres/main.tf
- cloud_sql/database_instance_sqlserver/main.tf
- cloud_sql/instance_cmek/main.tf
- cloud_sql/instance_ha/main.tf
- cloud_sql/instance_iam_condition/main.tf
- cloud_sql/instance_labels/main.tf
- cloud_sql/instance_pitr/main.tf
- cloud_sql/instance_ssl_cert/main.tf
Clean up tasks (What to do?)
Common issues
- Unlike the other samples in
cloud_sql
, these folder don't have prefixes likemysql
,postgres_
&sqlserver_
- Many of these samples like
instance_*/main.tf
, have snippetmysql
,postgres_
&sqlserver_
. Such file should be split up into multiple files.
Example instance_ha
should be split into mysql_instance_ha
, postgres_instance_ha
& sqlserver_instance_ha
The following require folder rename change
database_instance_my_sql
tomysql_database_instance
database_instance_postgres
topostgres_database_instance
database_instance_sqlserver
tosqlserver_database_instance
Why
As a user when I open cloudsql folder, I find the samples related to mysql
db, have a prefix of mysql
. This is easy to spot and use, but folders that being with instance
and database
does not provide this benefit.
Terraform Resources
No response
Detailed design
No response
Additional information
No response
Update: PR for re-organising the content is completed by @betsy-lichtenberg at #443
After updating Google Cloud docs, the pending cleanup will be completed!
Update: Mostly completed. A few minor cleanup tasks are on-going now.
PR is completed! Marking this as closed for now.