terraform-google-modules / terraform-docs-samples

Terraform samples intended for inclusion in cloud.google.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

style: default values for `name` parameter in Cloud Run samples

rogerthatdev opened this issue · comments

TL;DR

Currently, in Cloud Run samples, the google_cloud_run_service resource uses various generic values as the name, such ascloudrun-srv, cloud-run-service-name. For the sake of consistency, these names should be either meaningful to their intended function (example) or have a default generic value (something like my-cloud-run-service).

Terraform Resources

google_cloud_run_service

Detailed design

No response

Additional information

No response

Since this issue was logged, the only samples that use generic names appear to be:

  • Tasks (being addressed in #568, incidentally)
  • run/traffic_* samples
  • run/*_tag_* samples