terraform-aws-modules / terraform-aws-s3-bucket

Terraform module to create AWS S3 resources 🇺🇦

Home Page:https://registry.terraform.io/modules/terraform-aws-modules/s3-bucket/aws

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

version 3.8.2 - adding hard coded account numbers to the module

aserakhi opened this issue · comments

Description

Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration (see the examples/* directory for references that you can copy+paste and tailor to match your configs if you are unable to copy your exact configuration). The reproduction MUST be executable by running terraform init && terraform apply without any further changes.

If your request is for a new feature, please use the Feature request template.

  • I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Before you submit an issue, please perform the following first:

  1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
  2. Re-initialize the project root to pull down modules: terraform init
  3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

  • Module version [Required]:
    3.8.2
  • Terraform version:
  • Provider version(s):

Reproduction Code [Required]

Steps to reproduce the behavior:

Expected behavior

Dynamic or variable configuration of the feature

Actual behavior

Forced accounts numbers :

List of AWS regions where permissions should be granted to the specified Elastic Load Balancing account ID ( https://docs.aws.amazon.com/elasticloadbalancing/latest/application/enable-access-logging.html#attach-bucket-policy )

elb_service_accounts = {
us-east-1 = "127311923021"
us-east-2 = "033677994240"
us-west-1 = "027434742980"
us-west-2 = "797873946194"
af-south-1 = "098369216593"
ap-east-1 = "754344448648"
ap-south-1 = "718504428378"
ap-northeast-1 = "582318560864"
ap-northeast-2 = "600734575887"
ap-northeast-3 = "383597477331"
ap-southeast-1 = "114774131450"
ap-southeast-2 = "783225319266"
ap-southeast-3 = "589379963580"
ca-central-1 = "985666609251"
eu-central-1 = "054676820928"
eu-west-1 = "156460612806"
eu-west-2 = "652711504416"
eu-west-3 = "009996457667"
eu-south-1 = "635631232127"
eu-north-1 = "897822967062"
me-south-1 = "076674570225"
sa-east-1 = "507241528517"
us-gov-west-1 = "048591011584"
us-gov-east-1 = "190560391635"
}

Terminal Output Screenshot(s)

Additional context

Regions available before August 2022 have static AWS account numbers and won't change in the future, so we hard-code them into the module. You should not need to specify your AWS account number in the bucket policy to get ELB log delivery.