Ensure module uses aws_s3_bucket_acl resource

[Dave Heward]

Simple one really.

│ Warning: Argument is deprecated
│
│   with module.s3_bucket.aws_s3_bucket.this,
│   on main.tf line 5, in resource "aws_s3_bucket" "this":
│    5: resource "aws_s3_bucket" "this" {
│
│ Use the aws_s3_bucket_acl resource instead
│
│ (and 10 more similar warnings elsewhere)

[Denys Havrysh]

(and 10 more similar warnings elsewhere)
Not that simple I would say. See here, there's a lot of deprecated arguments:
https://registry.terraform.io/providers/hashicorp/aws/3.75.0/docs/resources/s3_bucket

It means almost entire module has to be rewritten using new resources.

[Dave Heward]

Indeed there is. That's a bit of scope creep. My issue did not say address all warnings. Fixing the issues warning should be easy enough.

[Anton Babenko]

Closing as duplicate of #139

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.