Signature mismatch for native method "crypto_generichash_blake2b_salt_personal()"

Question

Signature mismatch for native method "crypto_generichash_blake2b_salt_personal()"

jcihocki opened this issue 4 years ago · comments

Created a PR here, if you're interested: https://github.com/jcihocki/lazysodium-java/pull/

native method declared in Sodium.java has subKeyId as long, native method expects unsigned char * for both salt and personal so it should be byte[]

Gurpreet Paul · Answer 1 · Tue Jul 07 2020 05:59:56 GMT+0800 (China Standard Time)

Hey nice spot, I have updated this and will be available in the next release!

jcihocki · Answer 2 · Tue Jul 07 2020 06:00:38 GMT+0800 (China Standard Time)

Awesome, thank you!

Nathan Kurtyka · Answer 3 · Fri Jul 10 2020 00:19:21 GMT+0800 (China Standard Time)

@gurpreet- Hello! Any approximate timeline for the next release?

I only ask because we're considering migrating our production stack to LazySodium, and this issue might be a blocker.

Gurpreet Paul · Answer 4 · Fri Jul 10 2020 04:04:36 GMT+0800 (China Standard Time)

@nathankurtyka Will release a new version today! It contains a minor breaking change in order to fix some scrypt related methods.

Gurpreet Paul · Answer 5 · Fri Jul 10 2020 05:10:44 GMT+0800 (China Standard Time)

Fixed in release 4.3.0.

Gurpreet Paul · Answer 6 · Sat Jul 11 2020 07:22:29 GMT+0800 (China Standard Time)

I've migrated my CI infrastructure to AzureCI (#77) so now we also have the benefit of testing across platforms rather than just testing on Linux. Should be extra resilient to these failures.

Will update Lazysodium Android ASAP too.