Giters

tensorflow / model-analysis

Model analysis tools for TensorFlow

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

TimeSeriesView and PlotViewer broken due to incorrect model_module in HTML export

dynamix opened this issue · comments

commented

System information

  • Have I written custom code (as opposed to using a stock example script
    provided in TensorFlow Model Analysis)    : no
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian Buster
  • TensorFlow Model Analysis installed from (source or binary): binary
  • TensorFlow Model Analysis version (use command below): 0.22.1
  • Python version: 3.7.3
  • Jupyter Notebook version: 6.0.3

Describe the problem

Module loading fails via unpck.com due to incorrect naming.

model-analysis/tensorflow_model_analysis/notebook/jupyter/tfma_widget/widget.py

Line 55 in b5060f0

_model_module = traitlets.Unicode('tensorflow_model-analysis').tag(sync=True)
and

model-analysis/tensorflow_model_analysis/notebook/jupyter/tfma_widget/widget.py

Line 68 in b5060f0

_model_module = traitlets.Unicode('tensorflow_model-analysis').tag(sync=True)
should be tensorflow_model_analysis instead of tensorflow_model-analysis

commented

Thanks for debugging. Submitted a fix, should be in next release.