tell-k / sphinxjp.themes.basicstrap

Theme for Sphinx using Twitter Bootstrap

Home Page:https://sphinxjpthemesbasicstrap.readthedocs.io/en/latest/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrading bootstrap3.min.js to Bootstrap v3.4.1

westurner opened this issue · comments

bootstrap3.min.js has bootstrap v3.3.4

From https://getbootstrap.com/docs/3.4/getting-started/#download :

  • For v3, v3.4.1 is latest
  • For v4 (which does have different CSS class names), v4.3.1 is latest

None of these seem that pressing, given that user input is controlled and we're 'only generating static pages', but who knows:
https://www.cvedetails.com/vulnerability-list/vendor_id-19522/product_id-51406/Getbootstrap-Bootstrap.html

  • Does upgrading to v3.4.1 break anything in sphinxjp.themes.basicstrap?
    (see also #29 "Upgrading jquery.min.js")