tehmaze-labs / modem

XMODEM, YMODEM and ZMODEM implementations in Python

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ymodem.py inital packet is too large in send()

ApiumJacob opened this issue · comments

Total packet length should only be 128 or 1024 bytes. The payload (data) being passed to the _send_packet() is already 128 or 1024 byte, that coupled with the additional transmission of the start_char, the sequence (2 bytes) and the checksum (2 bytes) makes the packet too large by five bytes.

This issue is in error, the payload should be 128 bytes, the total packet size is 133 bytes.