SmallDateTime has incorrect upper bound range (fix PR included)

Question

SmallDateTime has incorrect upper bound range (fix PR included)

rockymadden opened this issue 3 months ago · comments

Rocky Madden commented 3 months ago

Software versions

Tedious: 16.7.1 forward (via 1c88d76)
SQL Server: N/A
Node.js: N/A

Any other details that can be helpful

The upper bound should be June 6th and not May 6th, per the docs (January 1, 1900, through June 6, 2079): https://learn.microsoft.com/en-us/sql/t-sql/data-types/smalldatetime-transact-sql?view=sql-server-ver16
Fix PR (do not care if used or not): https://github.com/tediousjs/tedious/pull/1621/files#diff-d2490332c75e78831174c99cb403799aba574d24dcf18a92cf6293fe25d96490

Michael Sun · Answer 1 · Wed May 01 2024 02:23:45 GMT+0800 (China Standard Time)

@rockymadden Thanks for catching this and made the PR 🙇 . I just added a comment under the PR for remove a failing test case. It is no longer needed, and the PR should be good to go.