teddyzeenny / ember-mocha-adapter

A mocha adapter for ember-testing.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Race condition sometimes generates error `null` is not a function

lcoq opened this issue · comments

I encountered a problem, probably due to a race condition.

The d() method call sometimes fails and results in an error null is not a function.

I cannot clearly reproduce the problem, but it did not appear again since I change the line linked above with this one:

if (d) { d(); }

Please let me know if it seems an acceptable fix so I can submit you a PR.

Thanks !

This seems like a workaround, not a fix.

The only place where done is set to null is here; in which case the timeout is cleared and shouldn't be called .

Did you make sure you are using latest master?

I definitely agree with you, this does not seems like a proper fix.

I was using latest master when I had this issue, but I have now updated a lot of my spec files and I am not able to reproduce this issue, so I close it for now, and will reopen it if I encounter it again.

Thanks for your help anyway @teddyzeenny !

I close the issue and will reopen it if I encounter it again.