Move away from deprecated master role
twistedgrim opened this issue · comments
It would be nice to move to the newer control plane taints on nodes that are used as control plane nodes. As people use the playbook and charts and apps rely on the control plane taint more than a master taint it will start to cause issues. More info below.
Migrate from the old deprecated master taint to the new control-plane taint.
Kubernetes docs from 1.20 show this change.
-
The label applied to control-plane nodes "node-role.kubernetes.io/master" is now deprecated and will be removed in a future release after a GA deprecation period.
-
Introduce a new label "node-role.kubernetes.io/control-plane" that will be applied in parallel to "node-role.kubernetes.io/master" until the removal of the "node-role.kubernetes.io/master" label.
-
Make "kubeadm upgrade apply" add the "node-role.kubernetes.io/control-plane" label on existing nodes that only have the "node-role.kubernetes.io/master" label during upgrade.
-
Please adapt your tooling built on top of kubeadm to use the "node-role.kubernetes.io/control-plane" label.
-
The taint applied to control-plane nodes "node-role.kubernetes.io/master:NoSchedule" is now deprecated and will be removed in a future release after a GA deprecation period.
-
Apply toleration for a new, future taint "node-role.kubernetes.io/control-plane:NoSchedule" to the kubeadm CoreDNS / kube-dns managed manifests. Note that this taint is not yet applied to kubeadm control-plane nodes.
Same issue with hardcoded names "master" in the roles.
@twistedgrim
CC: @egandro
This seems to be fixed with the introduction of group_name_master.
IMO, this can be closed.
closed by #337