FFC dimensions borked
maxfierke opened this issue · comments
The front facing camera takes pictures all right but the preview and snapshot dimensions are switched (landscape when they should be portrait). The fix should be pretty easy, but it's probably very tedious to figure out.
Maybe someone with a CCACHE setup can figure it all out because compiling will take 5 minutes.
Please take note of my comments in issue#15 (closed... duplicate of this issue)
Im not sure you understood what I failed to explain. This issue was briefly discussed in the xda thread. The pictures are not being taken properly like Max states about it looks like the picture is four images stacked on top of each other. In the picture linked you can see four images of my head. I think its similar to this but some very different issues.
Rather then looking at this from a "set of issues" POV... I'm looking at this from the "code that changed" POV.
The FFC (s5ka3dfx) came from GB Crespo.
teamacid/android_kernel_galaxys4gmtd@51db45b
Looking at the code changes, I'm not sure that I agree with these changes.
As well, the device tree libcamera changes came from ICS:
The mismatch could cause many issues and I feel they are related.
Ok I understand what you are saying now Bryan. Would a log from any stock buil work or would we need one from a phone flashed to kj6 stock? I had so many problems getting back on CM7 after a flub Im scared to go back right now. I might be able to get somebody from xda to get a log tho if any bml build would work.
airfluip1: Not sure why we changed ffc. That'll be a m4xm4n question, and he is AFK. (on second thought, I think it's because we are now building libcamera from source, whereas previously we were using the proprietary binary.)
Eollie: hehe, I'll go back to bml and check it out.
Fixed in CM9/AOKP as of commit 5d73b83 on the device tree (this) and commit teamacid/android_kernel_galaxys4gmtd@8e12572 on kernel.
Fixed in CM7 as of commit 7141edb