Tests broken on v2.80.2

Question

Tests broken on v2.80.2

arobase-che opened this issue 6 months ago · comments

Hello,

Thank you for the projet, I don't use it every day but it's awesome.

The tests are broken on the latest release (v2.20.8) and on master.
Here are the errors:

$ go test ./...
minify/minify.go:29:26: cannot use &aspMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)
minify/minify.go:30:37: cannot use &aspMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)
minify/minify.go:34:41: cannot use &phpMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)
minify/minify.go:38:36: cannot use &tmplMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)
minify/minify.go:39:42: cannot use &tmplMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)
minify/minify.go:40:44: cannot use &tmplMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)
# github.com/tdewolff/minify/v2/minify [github.com/tdewolff/minify/v2/minify.test]

Have a good day. 👍

Taco de Wolff · Answer 1 · Thu Nov 30 2023 20:04:34 GMT+0800 (China Standard Time)

Thanks for the fix!

…

On Wed, Nov 29, 2023, 22:58 ache ***@***.***> wrote: Hello, Thank you for the projet, I don't use it every day but it's awesome. The tests are broken on the latest release (v2.20.8) and on master. Here are the errors: $ go test ./... minify/minify.go:29:26: cannot use &aspMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify) minify/minify.go:30:37: cannot use &aspMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify) minify/minify.go:34:41: cannot use &phpMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify) minify/minify.go:38:36: cannot use &tmplMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify) minify/minify.go:39:42: cannot use &tmplMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify) minify/minify.go:40:44: cannot use &tmplMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify) # github.com/tdewolff/minify/v2/minify [github.com/tdewolff/minify/v2/minify.test] Have a good day. 👍 — Reply to this email directly, view it on GitHub <#640>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKOGHTLBIW4J6EYUEOET33YG7R5VAVCNFSM6AAAAABAANPDMKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYTONZSG44TINA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>