tclindner / npm-package-json-lint

Configurable linter for package.json files

Home Page:https://npmpackagejsonlint.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

overrides doesn't work with --configFile option

dangreen opened this issue · comments

config:

module.exports = {
  rules: {
    'require-keywords': 'off',
    'require-private': 'error',
    'valid-values-private': ['error', [true]]
  },
  overrides: [
    {
      patterns: ['packages/*/package.json'],
      rules: {
        'require-private': 'off',
        'valid-values-private': 'off',
        'require-repository-directory': 'error'
      }
    }
  ]
}

Works well:

npmPkgJsonLint .

Doesn't work:

npmPkgJsonLint -c ./.npmpackagejsonlintrc.json .
./packages/babel-preset/package.json
✖ require-private - node: private - private is required
1 error
0 warnings

./packages/browserslist-config/package.json
✖ require-private - node: private - private is required
1 error
0 warnings

./packages/eslint-config/package.json
✖ require-private - node: private - private is required
1 error
0 warnings

./packages/lint-package-json/package.json
✖ require-private - node: private - private is required
1 error
0 warnings

./packages/npm-package-json-lint-config/package.json
✖ require-private - node: private - private is required
1 error
0 warnings

./packages/scripts/package.json
✖ require-private - node: private - private is required
1 error
0 warnings

Totals
6 errors
0 warnings
0 files ignored

Thank you for reporting this, @dangreen. I think I found the culprit. Let me know if v6.0.3 works for you!