Add tests for Object rest/spread properties

Question

Add tests for Object rest/spread properties

leobalter opened this issue 8 years ago · comments

@sebmarkbage do you already have someone working on the tests for this proposal? If not, we might take this task.

Sebastian Markbåge · Answer 1 · Thu Feb 16 2017 02:17:00 GMT+0800 (China Standard Time)

I've started converting from the other Array rest/spread cases so that we cover the same scenarios. Unfortunately I've had to take a break on this until mid-March, so any help would be appreciated.

Daniel Ehrenberg · Answer 2 · Thu Feb 16 2017 02:20:33 GMT+0800 (China Standard Time)

@gsathya has checked in a number of tests into V8; those might be a good starting point

Sebastian Markbåge · Answer 3 · Thu Feb 16 2017 02:26:13 GMT+0800 (China Standard Time)

Also see these from WebKit tc39/proposal-object-rest-spread#32 (comment)

Caio Lima · Answer 4 · Thu Feb 16 2017 20:37:17 GMT+0800 (China Standard Time)

@sebmarkbage If you are ok, I can submit a PR with WebKit's tests here.

Sebastian Markbåge · Answer 5 · Fri Feb 17 2017 02:40:51 GMT+0800 (China Standard Time)

@caiolima That'd be great!

Leo Balter · Answer 6 · Fri Feb 17 2017 03:37:10 GMT+0800 (China Standard Time)

Caio, for test262 perspective, this would be great and we can coordinate the tests migration. I'll send you an email and see if we can connect in a video call. It's not really necessary but great as we can talk about it in our native language. :)

Caio Lima · Answer 7 · Fri Feb 17 2017 08:38:44 GMT+0800 (China Standard Time)

@leobalter sure! I'm planing to work on that tomorrow and during the weekend. I've seen that array Rest/spread tests are slightly different from the last PR I've submitted, since they are generated from sources into src/dstr-assignment, but I can figure out its pattern.

Caio Lima · Answer 8 · Thu Feb 23 2017 22:39:38 GMT+0800 (China Standard Time)

@leobalter and @sebmarkbage, I've opened the PR #867 with a initial set of tests for Object Rest deconstruction. But I have 2 questions before go further:

What Am I supposed to put in esid field?
I want to add some syntax tests, but I'm confused if I should add them and also where should I place them.

I'm planing to create tests for Object Spread this weekend.

Leo Balter · Answer 9 · Mon Mar 13 2017 22:26:53 GMT+0800 (China Standard Time)

#867 #890 and #892 should be covering Object Rest Spread for now. I'll check if we find more edge cases - and compare with the tests on v8. I'll follow up w/ new PRs if I find more coverages to fill.

credits to @caiolima who did a great work here!

Leo Balter · Answer 10 · Fri Aug 04 2017 05:34:04 GMT+0800 (China Standard Time)

I am reopening this because of a few extra items:

#1050
#1132

Adrian Heine né Lang · Answer 11 · Mon Nov 13 2017 17:33:08 GMT+0800 (China Standard Time)

I think the negative tests for complex rest properties are still missing.

Leo Balter · Answer 12 · Tue Nov 14 2017 00:20:36 GMT+0800 (China Standard Time)

Thanks for letting me know, I'll get this fixed today.