Improve the viewport algorithm

Question

Improve the viewport algorithm

tbranyen opened this issue 8 years ago · comments

There is an insane amount of waste between renders during scroll events. Maybe use Sets to track elements and only request new rows to account for the difference. This would greatly improve the scrolling on mobile. It would also eat up less memory and have less redraw cost.

Tim Branyen · Answer 1 · Tue May 02 2017 00:04:31 GMT+0800 (China Standard Time)

@soyuka any thoughts on what I was thinking here wrt to finding the difference between new and old sets to update changed elements?

Antoine Bluchet · Answer 2 · Tue May 02 2017 00:11:18 GMT+0800 (China Standard Time)

I'm not sure to understand and I think that performance have been improved with my refactoring (from position is more precise, less rendered items).

If you're talking about caching _getRow calls, I think it's not necessary.

Tim Branyen · Answer 3 · Tue May 02 2017 00:18:20 GMT+0800 (China Standard Time)

Okay cool, I definitely noticed an improvement with perf from your code changes. We have an app here at Netflix that uses HyperList and we cache a Set that gets used by _getRow calls, so if you need this its definitely possible to do outside of HyperList.