Overrides nvim-nonicons

[Chinmay Dalal]

Hello, I use nvim-nonicons
When I set devicons_enable = true in lir.setup({}) everything (expressline, telescope) uses the default web-devicons instead of nonicons

[tamago324]

Thank you for reporting.
I'll ask the nvim-nonicons as well.

[Chinmay Dalal]

I tried adding pcall(vim.fn, "PackerLoad nvim-nonicons") before calling lir.setup{} too, didn't work

[tamago324]

Sorry. I do not use packer, so I do not know how it behaves.

[tamago324]

Sorry if I'm wrong, but isn't it pcall(vim.cmd, "PackerLoad nvim-nonicons"), not pcall(vim.fn, "PackerLoad nvim-nonicons")?

[Chinmay Dalal]

Ahhh
Edit: still doesn't work

[tamago324]

I wonder why...

[tamago324]

Could you please try the use-set_icon branch in the tamago324/nvim-nonicons repository?

[Chinmay Dalal]

All the other icons are correct, but the generic file icon (when a file has no filetype) is still the one from nvim-web-devicons.

Thanks!

[tamago324]

I modified it to override the default icon as well (tamago324/nvim-nonicons@a7cfa8d).
I'm sorry to keep repeating this, but could you please check?

[Chinmay Dalal]

You have to pass arguments to set_default_icon normally, not as a table

devicons.set_default_icon(
    get("file"),
    "#6d8086"
    --name = "Default",
)

Otherwise, yes this is fixed. Thanks again!

[Chinmay Dalal]

https://github.com/kyazdani42/nvim-web-devicons/blob/ee101462d127ed6a5561ce9ce92bfded87d7d478/lua/nvim-web-devicons.lua#L1096

and

https://github.com/kyazdani42/nvim-web-devicons/blob/ee101462d127ed6a5561ce9ce92bfded87d7d478/lua/nvim-web-devicons.lua#L1106

[tamago324]

I'm sorry. I just realized it!
Thank you for confirming!

[Chinmay Dalal]

I think this can be closed?