talonhub / community

Voice command set for Talon, community-supported.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"oh" for zero in number_small no longer works as of #993

rntz opened this issue · comments

As mentioned in https://github.com/knausj85/knausj_talon/pull/993/files#r990815249, merging the PR #993 removed the ability to say "oh" as a synonym for "zero" in number_small, so we technically changed the grammar.

Personally I found "oh" prone to misrecognitions and had carefully changed all my number captures to avoid allowing it at the start of a number - so I can say one oh one but not oh oh seven, for instance. So I won't run into this issue.

Is it worth fixing this and restoring "oh"? Or, conversely, might it be better to remove "oh" from more places?

I use 'oh' quite a bit and do not find that this triggers misrecognitions for me. I dictate a lot of large (ID) numbers, for example I just said "30063801" as "three hundred over sixty three eight oh one". This did not break with #993, but I agree with you that I don't ever use "oh" at the beginning of a number, I'll always use "zero" if it comes to it.