Add terminate char in builder?

Question

Add terminate char in builder?

johtani opened this issue 4 years ago · comments

Now, the builder expects that keys have a terminal character.
But, it is easy to use user only provides key and value.

What do you think?

Takuya Asano · Answer 1 · Sun Sep 27 2020 00:53:12 GMT+0800 (China Standard Time)

Thank you for your cool feedback.
The keys must end with \0 at this moment for simplicity of DoubleArrayBuilder.
But I agree with your suggestion that the keys don't need a \0, which is easier to build a double array.
I will try to improve it.

Takuya Asano · Answer 2 · Mon Sep 28 2020 01:44:22 GMT+0800 (China Standard Time)

@johtani I published a new version 0.3.0 which does not require us to append the \0 anymore. Please take a look.
https://crates.io/crates/yada