takuseno / d3rlpy

An offline deep reinforcement learning library

Home Page:https://takuseno.github.io/d3rlpy

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Any reason about depcrecating cython

im-Kitsch opened this issue · comments

Hi,

I am curious why cython dependency is removed. I remembered that in 'v1' verstion there is fancy implementation of dataset structure. Especially for sharing memory things. And I am planning to implenment similar structure. But looks it's deprecated in v2, is there any reason about derpecating? maybe performance limitation or cython problem?

Thanks

@im-Kitsch Hi, thanks for the issue. The reason why I switched from Cython to full Pythonic implemenation was to provide flexibility to users. Previously, logics underlying MDPDataset cannot be modified because those components need to be compiled when the package is released. To support various use cases, I decided to change the design.

thanks for the reply