taiki-e / find-crate

Find the crate name from the current Cargo.toml.

Home Page:https://docs.rs/find-crate

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`find-crate 0.7.0` release

str4d opened this issue · comments

There has been significant and consistent development on this crate since v0.6.3 was published in January 2021. In particular, find-crate 0.6.3 depends on toml 0.5.2, while current HEAD depends on toml 0.8. It would be nice to have a new release to enable crates like i18n-embed-impl (and its downstream users) to de-duplicate their toml dependencies. Are there any blockers remaining on a new release?

I'm hesitant to release a version that depends on toml 0.6+ because of increased dependencies and compile time, frequent breaking releases, and aggressive MSRV bumping done even when not needed, since toml 0.6.

Frequent breaking releases are not a problem if we are not using toml on the public API, and aggressive MSRV bumps are not much of a concern for a binary crate that does not care about high MSRV, but unfortunately this crate is neither.

So I would like to at least remove toml crate from the public APIs before the next breaking release.

It is currently used by the following two public APIs, and it would be reasonable to change the former to an opaque error type and the latter to an API that takes &str.

Toml(toml::de::Error),

pub fn from_toml(manifest: Table) -> Self {

I have heard that recent versions have improved somewhat with regard to compile time, but moving to a crate like basic-toml may be a more reasonable solution.