ParseFragment should be in public API

Question

ParseFragment should be in public API

clarfonthey opened this issue 3 years ago · comments

Clar Fon commented 3 years ago

Since it's provided to converters when calling them, it should be importable as kdl.ParseFragment.

Tab Atkins Jr. · Answer 1 · Sat Oct 30 2021 07:00:55 GMT+0800 (China Standard Time)

My thought was that there's never any reason to create one, so exposing it wasn't very necessary.

Tho hm, I suppose you do need access to it to write type signatures, if nothing else. Okay, I'll export it.

Tab Atkins Jr. · Answer 2 · Sat Oct 30 2021 07:06:58 GMT+0800 (China Standard Time)

And cut a new version 1.0.5.

Clar Fon · Answer 3 · Sat Oct 30 2021 08:21:21 GMT+0800 (China Standard Time)

Thank you!

And yeah, I'm not exactly sure how you could export it as just a type definition and not the class itself, but at least for the moment it's useful for type definitions.