tabakg / potapov_interpolation

The purpose of this package is to characterize a network of optical components when time delays with feedback are present.

Home Page:http://potapov-interpolation.readthedocs.io/en/latest/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

With get_roots_rect increasing N following imprecise warning appears to be ineffective. Also, warning is not consistent.

petersbingham opened this issue · comments

The issue can be demonstrated using the additional test cases added to the fork here:
https://github.com/petersbingham/potapov_interpolation/blob/Potapov_PolyRootTests/Potapov_Code/tests/tests_Roots.py

eg:

test_Poly_Roots(4, printRoots=False, printPolys=False, printParams=True, doubleOnWarning=True)

If the above is executed then each time the warning occurs the N is automatically doubled. The routine will double from 5000 to 1280000 without rectifying this warning. After this N I quit the routine as it was taking a very long time to complete.

Also, when the test_Poly_Roots is executed for other Ns (eg 11) imprecise roots are returned without any warning. See #11