t2v / play2-auth

Play2.x Authentication and Authorization module

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Need debug logging when authorization failed

tototoshi opened this issue · comments

When authorization failed from exception thrown by underlying modules like db or cache api, the detail is ignored and not recorded. Due to this, debugging is very hard.

https://github.com/t2v/play2-auth/blob/release0.14.2/module/src/main/scala/jp/t2v/lab/play2/auth/AsyncAuth.scala#L9-L22

Will you add debug logging where recover and recoverWith?

} recoverWith {
      case e =>
           logger.debug(e.getMessage, e)
           authenticationFailed(request).map(Left.apply)
}

Good proposal!

I consider the way of getting logger instance...

why not play.api.Logger?