play 2.4 builds.

Question

play 2.4 builds.

indykish opened this issue 9 years ago · comments

Kishorekumar Neelamegam commented 9 years ago

Hi i tested out play 2.4 RC3 with our code
https://github.com/megamsys/megam_gateway.git

As play-auth depends on 2.3, my cache in play 2.4 gets evicted, hence my app fails to run saying "NoClass def found for CachePlugin"

Can you make a snapshot for 2.4 ?

Manabu Nakamura · Answer 1 · Mon May 18 2015 15:55:43 GMT+0800 (China Standard Time)

Alright, I'll publish SNAPSHOT for 2.4-RC

Kishorekumar Neelamegam · Answer 2 · Thu May 28 2015 12:32:16 GMT+0800 (China Standard Time)

@gakuzzzz Play 2.4 was released today. Can you make a snapshot or 0.13.3 ?

Manabu Nakamura · Answer 3 · Thu May 28 2015 16:37:56 GMT+0800 (China Standard Time)

I published 0.14.0-SNAPSHOT that contains #133

However it fails tests.
Would you help me?

Kishorekumar Neelamegam · Answer 4 · Thu May 28 2015 17:14:07 GMT+0800 (China Standard Time)

Yes.

A quick note play 2.4 only works with JDK 1.8

I see a Cache problem in the travis ci. The api was changed in 2.4.

Manabu Nakamura · Answer 5 · Thu May 28 2015 17:33:35 GMT+0800 (China Standard Time)

Thanks, I removed oraclejdk7 from travis settings.

Kishorekumar Neelamegam · Answer 6 · Thu May 28 2015 18:00:54 GMT+0800 (China Standard Time)

Ok. I will fork and check it out later in the day (after 6 hrs) 👍 Good work @gakuzzzz

barcahead · Answer 7 · Mon Jun 01 2015 13:25:13 GMT+0800 (China Standard Time)

any update for play 2.4 support?

Manabu Nakamura · Answer 8 · Mon Jun 01 2015 13:58:03 GMT+0800 (China Standard Time)

It is blocked by some Play2 issue
playframework/playframework#4488
playframework/playframework#4591

If you don't need to use CacheIdContainer, would you use 0.14.0-SNAPSHOT?

barcahead · Answer 9 · Mon Jun 01 2015 15:14:53 GMT+0800 (China Standard Time)

@gakuzzzz how to include 0.14.0-SNAPSHOT in play2.4 project?

Manabu Nakamura · Answer 10 · Mon Jun 01 2015 15:20:35 GMT+0800 (China Standard Time)

add Sonatype snapshot resolver and add dependency play2-auth 0.14.0-SNAPSHOT

resolvers += Resolver.sonatypeRepo("snapshots")
libraryDependencies += "jp.t2v" %% "play2-auth" % "0.14.0-SNAPSHOT"

barcahead · Answer 11 · Mon Jun 01 2015 17:25:32 GMT+0800 (China Standard Time)

@gakuzzzz got it, thanks

Adam Lane · Answer 12 · Tue Jun 02 2015 06:25:35 GMT+0800 (China Standard Time)

FYI When I use 0.14.0-SNAPSHOT everything works fine in dev mode but in production (start) mode the login page just redirects back to login. Changing back to 0.13.2 appears to work fine for me with play 2.4. (I believe I am just following the basic usage from instructions and the stateless idContainer override)

Manabu Nakamura · Answer 13 · Tue Jun 02 2015 09:35:34 GMT+0800 (China Standard Time)

Thanks for reporting.
It is a intended behavior. the TokenAccessor default implementation is changed to more secure.
https://github.com/t2v/play2-auth/pull/133/files#diff-6f968b3524e16933f29a65ff5ece7471R53
In production, use SSL or override cookieSecureOption to false explicitly.

Brian Wawok · Answer 14 · Thu Jun 18 2015 01:01:31 GMT+0800 (China Standard Time)

So what is the status on this? We are waiting on a play 2.4.1 release, no more changes needed on the play2 auth side?

I tried a few weeks ago with 2.4.0 and hit all the problems described above.. have not tried again, because the play changes are kind of a pain.

Manabu Nakamura · Answer 15 · Fri Jun 19 2015 11:27:41 GMT+0800 (China Standard Time)

sorry waiting for this.
It still has #133 test failure and It needs changing test helper API from #136.

If you have a nice idea that solves these, would you PR it?

Michał Jurczuk · Answer 16 · Fri Jun 26 2015 03:55:44 GMT+0800 (China Standard Time)

now we have a 2.4.1 and playframework/playframework#4488 is fixed, will it work now?

Manabu Nakamura · Answer 17 · Sun Jul 05 2015 16:42:24 GMT+0800 (China Standard Time)

0.14.0 has released