Suggestion: Return null if rule parsing error?

Question

Suggestion: Return null if rule parsing error?

JanPetterMG opened this issue 9 years ago · comments

Jan-Petter Gundersen commented 9 years ago

Sometimes, when the robots.txt file cannot be parsed properly, we get problematic results. This may happen on bad robots.txt files, and doesn't always mean there is a issue with the code.

For example:
isAllowed('/') = (bool) false
and
isDisallowed('/') = (bool) false

For now, the only way to check for errors, is to check both isAllowed and isDisallowed and then verify if the results looks normal.
What about doing this before returning the result? and return a NULL value for example?

Any thoughts?

Jan-Petter Gundersen · Answer 1 · Sun Sep 27 2015 07:50:48 GMT+0800 (China Standard Time)

Pull Request #25

Igor Timoshenkov · Answer 2 · Mon Oct 12 2015 19:33:08 GMT+0800 (China Standard Time)

I would rather go with throwing an Exception if the file is bad, but I guess for now null is ok. As already commented on the pull request - please fix the test also. Otherwise - the code looks ok 👍 thanks for the effort!

Jan-Petter Gundersen · Answer 3 · Mon Oct 12 2015 22:50:29 GMT+0800 (China Standard Time)

I agree, better to throw an exception. I just updated my own code locally, and I'll submit it once I get PHPUnit up and running. Newer used it before, so it may take some time to figure out how it works. (im not a pro, just a hobby developer)...

Igor Timoshenkov · Answer 4 · Fri Oct 16 2015 00:55:21 GMT+0800 (China Standard Time)

Ok. Should be merged. Can we close this?

Jan-Petter Gundersen · Answer 5 · Fri Oct 16 2015 01:30:05 GMT+0800 (China Standard Time)

Yup, now it's all good :)