problem when I try to run jspm-react boilerplate codebase

Question

problem when I try to run jspm-react boilerplate codebase

capaj opened this issue 8 years ago · comments

When running unit tests, I get:
(SystemJS) /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:136
$traceurRuntime.canonicalizeUrl = canonicalizeUrl;
^
ReferenceError: $traceurRuntime is not defined
at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:136:3
at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:140:3
at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:3859:23
at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:42896:3
at Object.exports.runInThisContext (vm.js:54:17)
Evaluating /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js
Error loading /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js as "systemjs-babel-build" from /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/plugin-babel.js
Error loading /var/www/zahrajeme.cz/public/routes/home.js
(SystemJS) /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:136
$traceurRuntime.canonicalizeUrl = canonicalizeUrl;
^
ReferenceError: $traceurRuntime is not defined
at public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:136:3
at public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:140:3
at public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:3859:23
at public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js:42896:3
at Object.exports.runInThisContext (vm.js:54:17)
Evaluating /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js
Error loading /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/systemjs-babel-node.js as "systemjs-babel-build" from /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.10/plugin-babel.js
Error loading /var/www/zahrajeme.cz/public/routes/home.js

I am using babel-why would it try to use traceur?

Guy Bedford · Answer 1 · Sun Jun 19 2016 08:11:37 GMT+0800 (China Standard Time)

Make sure to run version 0.0.12 of plugin-babel.

Jiri Spac · Answer 2 · Sun Jun 19 2016 08:25:15 GMT+0800 (China Standard Time)

@guybedford that helps, but I have stumbled on another crash in there:

(SystemJS) /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:22574
      var fd = parseInt(process.env.DEBUG_FD, 10) || 2;
                               ^
    TypeError: Cannot read property 'env' of undefined
        at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:22574:28
        at l (/var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:2178)
        at i (/var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:1812)
        at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:2256
        at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:34422:17
        at l (/var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:2178)
        at i (/var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:1812)
        at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:2256
        at /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:39437:15
        at l (/var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/systemjs-babel-node.js:1:2178)
    Evaluating /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/plugin-babel.js
    Error loading /var/www/zahrajeme.cz/public/jspm_packages/npm/systemjs-plugin-babel@0.0.12/plugin-babel.js
    Error loading /var/www/zahrajeme.cz/public/routes/home.js

Which is weird, since I am running it from node.js, so process should be on global scope.

Guy Bedford · Answer 3 · Sun Jun 19 2016 20:42:31 GMT+0800 (China Standard Time)

@capaj is the process global definitely available here?

Guy Bedford · Answer 4 · Sun Jun 19 2016 20:43:39 GMT+0800 (China Standard Time)

Basically, something must nulled out global.process because that doesn't happen in the build file itself.

Jiri Spac · Answer 5 · Mon Jun 20 2016 04:02:50 GMT+0800 (China Standard Time)

@guybedford I tried putting console.log(process.env) just before I call System.import('routes/home') and it logged out env variables as it should. It gets nulled somewhere there, I will try a setter to find who is deleting it.

Jiri Spac · Answer 6 · Mon Jun 20 2016 04:12:54 GMT+0800 (China Standard Time)

In this case process is not the global process in node, but a locally scoped variable defined as:
var process = $__require("3");

Is this all built properly @guybedford ?

Guy Bedford · Answer 7 · Mon Jun 20 2016 04:27:12 GMT+0800 (China Standard Time)

If you look at System.registerDynamic("3" you will see it is just exporting global.process though?

Jiri Spac · Answer 8 · Mon Jun 20 2016 04:27:18 GMT+0800 (China Standard Time)

so I have found out what is breaking it-the way I instrument those tests:

require('systemjs')
System.config({
  baseURL: 'public/'
})
require('./public/jspm.browser')
require('./public/jspm.config')

require('babel-register')

const Mocha = require('mocha')
const glob = require('glob')
const jsdom = require('jsdom')
const mocha = new Mocha()

const doc = jsdom.jsdom('<!doctype html><html><body></body></html>')
const win = doc.defaultView
global.document = doc
global.window = win
global.navigator = win.navigator
// take all properties of the window object and also attach it to the
// mocha global object
propagateToGlobal(win) //this breaks it, when commented out, tests run

// from mocha-jsdom https://github.com/rstacruz/mocha-jsdom/blob/master/index.js#L80
function propagateToGlobal (window) {
  for (let key in window) {
   // note that global.process is not overwritten by this
    if (!window.hasOwnProperty(key)) continue
    if (key in global) continue

    global[key] = window[key]
  }
}

The last call to propagateToGlobal breaks it. When I remove it, tests run as expected. Maybe systemjs might get confused about the environment it's running in and fail to supply process to that particular module?

Jiri Spac · Answer 9 · Mon Jun 20 2016 04:29:59 GMT+0800 (China Standard Time)

@guybedford yes indeed:

$__System.registerDynamic("3", ["@system-env"], true, function($__require, exports, module) {
  ;
  var define,
      global = this,
      GLOBAL = this;
  var productionEnv = $__require('@system-env').production;
  var pEnv = process.env;
  pEnv.NODE_ENV = productionEnv ? 'production' : 'development';
  module.exports = global.process;
  return module.exports;
});

Guy Bedford · Answer 10 · Mon Jun 20 2016 04:31:47 GMT+0800 (China Standard Time)

Does it work if you change the line module.exports = global.process to just module.exports = process?

Jiri Spac · Answer 11 · Mon Jun 20 2016 04:34:11 GMT+0800 (China Standard Time)

@guybedford oh yes. I am a bit confused. Shouldn't they be the same?

EDIT: oh now I see that bit:

  var define,
      global = this,
      GLOBAL = this;

Guy Bedford · Answer 12 · Mon Jun 20 2016 04:36:52 GMT+0800 (China Standard Time)

Sure, I've updated that in the original repo.

Jiri Spac · Answer 13 · Mon Jun 20 2016 04:37:18 GMT+0800 (China Standard Time)

@guybedford where was that?

Guy Bedford · Answer 14 · Mon Jun 20 2016 04:39:00 GMT+0800 (China Standard Time)

https://github.com/jspm/nodelibs-process