CPUQuota= values > 100% are invalid since v231
djgera opened this issue · comments
Submission type
- [X ] Bug report
- Request for enhancement (RFE)
NOTE: Do not submit anything other than bug reports or RFEs via the issue tracker!
systemd version the issue has been seen with
v231
NOTE: Do not submit bug reports about anything but the two most recently released systemd versions upstream!
Used distribution
Arch Linux (x86_64)
In case of bug report: Expected behaviour you didn't see
$ sudo systemctl --runtime set-property ghb@:1.service CPUQuota=200%
$
In case of bug report: Unexpected behaviour you saw
$ sudo systemctl --runtime set-property ghb@:1.service CPUQuota=200%
CPU quota '200%' invalid.
In case of bug report: Steps to reproduce the problem
$ sudo systemctl --runtime set-property ghb@:1.service CPUQuota=200%
@vcaputo could you take a look at this? Related to coreos/coreos-overlay#2106
Looks like it was introduced in 9184ca4 since parse_percent checks the value is in the range [0,100]. Looking through the man pages, it appears the CPUQuota is the only place where values >100% are used. Not sure if a "parse_percent_unbounded" should be introduced or just revert the change in that one spot.
I've tested using a parse_percent_unbounded function, which seems to work for me. The PR is #3886.
Huh, I only get notified on my personal email for this project, didn't see my mention til now. I believe dm0 is working on this.