Fix the upload script
certik opened this issue · comments
I had to disable pdf upload in #86, as it was not robust. To make it robust, we should:
- enable
set -e, i.e. fail on any error in the upload script - disable notifications for now (I think they already are), since they don't work
- figure out a robust way to do
git push. Perhaps it could work to pull first and then push. It depends if the failure is caused by some other Travis test pushing in changes after we pulled but before we pushed. Or if the failure is caused by something else, we need to investigate and fix it, perhaps try a few times, etc.
Would this be of interest: https://github.com/ewanmellor/gh-publisher/ ?
If we're not pulling before we push we should definitely do that.
Failures mentioned were because of PRs coming from forks. We should exit early if GH_TOKEN is empty
Is this fixed?
The script is still not using set -e, so this still needs to be fixed. The other two points seem to be fixed.