Non-daemon thread somewhere

Question

Non-daemon thread somewhere

pmonks opened this issue 7 years ago · comments

Somewhere in SJC (since at least v1.0.2) a thread is being created that's not a daemon thread (I suspect it's the thread that handles the data feed, but I haven't verified this). As a result the JVM won't terminate when the default main thread terminates, leaving bot processes hanging.

Frank Tarsillo · Answer 1 · Fri Oct 20 2017 05:07:18 GMT+0800 (China Standard Time)

It is the DataFeedWorker (in 1.0.2 version MessageFeedWorker) thread.

You have to call SymphonyClient.shutdown() to terminate.

Will look into handling this more gracefully..

Peter Monks · Answer 2 · Fri Oct 20 2017 06:25:27 GMT+0800 (China Standard Time)

Would it make sense to set the thread to be a daemon? Or does that leak resources somewhere?

DovOps · Answer 3 · Thu Nov 16 2017 00:27:52 GMT+0800 (China Standard Time)

In addition to the problems with deamon-ness, is simply identifying the thread. I've submitted PR #88 to address the latter issue so we have a better understanding of SymClient-spawned threads.

Frank Tarsillo · Answer 4 · Mon Dec 04 2017 10:52:30 GMT+0800 (China Standard Time)

Thanks @Dovie. Also added to new PresenceWorker..

Going to close this, but happy to reopen if we are seeing issues.