Giters

symphonyoss / symphony-java-client

Java client library for Symphony

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Do not include log4j in compile dependencies

oniseijin opened this issue · comments

commented

Currently, the dependency tree is as follows:

+--- org.slf4j:slf4j-api:1.7.21 -> 1.7.25
| +--- org.slf4j:slf4j-log4j12:1.7.21
| | +--- org.slf4j:slf4j-api:1.7.21 -> 1.7.25
| | --- log4j:log4j:1.2.17

Please don't include slf4j-log4j as a compile time dependency. Place it as a "runtime" dependency. Scoping details at https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html

Basically add runtime to you pom for org.slf4j:slf4j-log4j12. This is messing with the ability to use log4j 2.x in a project. API is correct to leave as compile scope.

commented

commit 8efb28e

Note: I will be switching to logback over the next few commits.