symmy596 / SurfinPy

Thermodynamic Phase Diagram Generator

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Jupyter in install requirements

awvwgk opened this issue · comments

The install requirements in setup.py list Jupyter, however this is not listed in the README.

commented

The examples we provide are created using jupyter notebooks and we feel for new user experience having jupyter would be a requirement.

Since jupyter is not crucial for the functionality of the package, it doesn't qualify as an install requirement. For optional dependencies there is a dedicated mechanism in setup.py which allows installations with features (i.e. pip install .[jupyter] or pip install .[tutorial]).

commented

Thank you for informing me of this feature.
I have no added jupyter to an optional extra under a Tutorials install and have updated the Readme with install instructions.