symfony / recipes-contrib

Symfony Contrib Recipes Repositories

Home Page:https://github.com/symfony/recipes-contrib/blob/flex/main/RECIPES.md

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[RFC] Let contributors be 100% responsible for their own recipe

maidmaid opened this issue · comments

This would relieve the time, effort and responsibility to core members. More, contributive recipes changes would be more quick and more active because they no longer depend on the expectation of a review/merge. To do this, @symfony-bot could be smart enough to merge PR when the following condition is valid:

author username === root dir of all changed files
&& all checks in symfony.sh are green
&& 'Status: MERGE' === last comment

the first condition you add would mean that any package owned by an organization would still require manual merging...

An improvement could be check also list user organizations; it's not technically impossible.

Auto-merging is on my list. But first, I need to be sure that the validator checks are rock solid. We're getting there :) I need more PRs with human reviews. That helps me add more checks.

About this, will you make open-source the code that drives @symfony-bot?

@maidmaid I have no plan to open-source the server part.

PRs on this repository are now merged automatically. Rules are simple. PRs are merged when the following conditions are met (in that order):

  • The Symfony Bot approved the pull request and reported no validation errors;

  • Someone approved the pull request (it can be anyone but the original author of the pull request).

Rules are still evolving, see #21 for more details