Tests: invalid comparation of float values

Question

Tests: invalid comparation of float values

WinterSilence opened this issue 2 years ago · comments

$this->assertEquals() and $this->assertSame() generates error like as
Failed asserting that 3.3333333333333335 is identical to 3.3333333333333. at comparing float values.

Need replace invalid assertion to $this->assertEqualsWithDelta():
$this->assertEqualsWithDelta(3.3333333333333335, 3.3333333333333, 0.0000001)
https://phpunit.readthedocs.io/en/7.5/assertions.html#assertequalswithdelta

Alexander M. Turek · Answer 1 · Fri Feb 25 2022 23:14:42 GMT+0800 (China Standard Time)

What exactly is the issue that you want to report?

Anton · Answer 2 · Fri Feb 25 2022 23:31:47 GMT+0800 (China Standard Time)

@derrabus failed tests/invalid assertion

Nicolas Grekas · Answer 3 · Sat Feb 26 2022 00:02:26 GMT+0800 (China Standard Time)

This is certainly not the right repository.

Anton · Answer 4 · Sat Feb 26 2022 00:07:11 GMT+0800 (China Standard Time)

@nicolas-grekas why? this massive problem for polyfill packages

Anton · Answer 5 · Sat Feb 26 2022 00:10:29 GMT+0800 (China Standard Time)

@nicolas-grekas this failed tests on sending PR https://github.com/symfony/polyfill/runs/5335784525?check_suite_focus=true

Nicolas Grekas · Answer 6 · Sat Feb 26 2022 22:42:17 GMT+0800 (China Standard Time)

Sorry I failed to understand that your were talking about the tests of this repo. Now that I see your PR it makes sense.

Anton · Answer 7 · Sun Feb 27 2022 00:18:55 GMT+0800 (China Standard Time)

@nicolas-grekas no problem, but why issue still close? Yes, this PR is "howto" for update same tests